Repository navigation
Conversation
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
|
The Generated by Claude Code |
|
The Generated by Claude Code |
|
The Generated by Claude Code |
|
Generated by Claude Code |
|
Generated by Claude Code |
|
The vector-core test failure on 10ca012 ( Generated by Claude Code |
|
CodeQL's two new high alerts on 752bdc2/56616efd ("Access of invalid pointer", Generated by Claude Code |
|
The vector-core failure on 7a4ebb0 is Generated by Claude Code |
| } | ||
|
|
||
| // SAFETY: `CredReadW` succeeded, so this points to a valid `CREDENTIALW` until `CredFree` below. | ||
| let result = unsafe { username_and_password(&*credentials) }; |
|
|
||
| let mut credentials: *mut CREDENTIALW = std::ptr::null_mut(); | ||
| unsafe { CredReadW(target_name, CRED_TYPE_GENERIC, None, &mut credentials) }.unwrap(); | ||
| let result = unsafe { username_and_password(&*credentials) }; |
|
Windows Generated by Claude Code |
|
The Generated by Claude Code |
|
The Generated by Claude Code |
|
The Generated by Claude Code |
|
The Generated by Claude Code |
|
The red Likely cause, proposed rather than pushed since it changes core timing: Generated by Claude Code |
A content mask now carries corner radii: an overflow-hidden element with rounded corners clips what it holds to its padding box's rounding (its radius less the border), mirrored with the layout. Quads, shadows, underlines, glyphs and images take the mask's coverage in their fragment shaders on Metal, DirectX and wgpu (WebGL decoders too). Menu rows, cards and players no longer poke square corners past a curved edge. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qq6RetJnzXvEeXAvSsgvs1
A content mask can carry vertical alpha ramps, applied in every primitive's fragment shader like the rounding, so a scroller fades its ends over any background, as Tauri's mask-image does. `edge_fade(depth)` on a scrolling div or list fades each end by as much as is left to scroll that way, up to depth: none at rest against an end. The chat and channel lists (wide layout) and the Community Rail fade over 24 px, as Tauri's do. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qq6RetJnzXvEeXAvSsgvs1
…oom under the lists Opening a chat marked read through the backend's in-memory copy, which can hold only our own latest message and then marks nothing, so the UI's marker never moved and the NEW divider came back on every open. Every read now names the newest message from someone else, as Tauri's markAsRead does. The chat list and the channel list end with Tauri's bottom padding (8 px wide, 16 px slim). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qq6RetJnzXvEeXAvSsgvs1
…ning mask fades The mask's fade gains left and right ramps, and a box can fade over fixed lengths as well as by the scroll left (Styled::edge_fades, Styled::fade_out). The lyrics sheet, clamped Nostr embeds, the collapsed edit history, the kaomoji tabs and the App Store shelves now fade as Tauri's masks do instead of under painted gradients, and the narrow layout's chat and channel lists fade too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qq6RetJnzXvEeXAvSsgvs1
Hover state read at layout only updated on mouse moves, so a row that came under a still pointer read unhovered at layout and hovered at paint, flipping its hover fade each frame. The paint-time hit test now writes the state layout reads. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qq6RetJnzXvEeXAvSsgvs1
…age, first-launch offer - vector-i18n: the index format (a kind 30078 event's content; a key hands over by naming its successor), English names for packs, en-* packs inherit en-GB for coverage, and the languages this build saw in the repository for offering before any download. - vector-i18n tool (feature sign): publish builds every language and signs the index, keygen makes the key, blossom-auth authorises one upload with a key of its own. - GPUI: the index is fetched on the shared lane and believed only when the pinned key (or a successor it named) signed it; packs come from Blossom by hash, then the release, and are checked against the index's hash and size. Installed packs update daily and swap in live; a device with none never asks. - Settings > Appearance > Language lists every language with its English name, coverage and size; picking one downloads it with progress and switches at once. - The welcome screen offers the system's language once, downloading only on Switch. - The en-US pack, and a CI job that publishes once VECTOR_LANGUAGES_KEY is set. The pinned key is a throwaway test key until then. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qq6RetJnzXvEeXAvSsgvs1
…an't reach the release The app asks the release first and Vector's trusted relays when it can't, through a scratch client on the shared lane, following each key handover the same way. CI hands the signed events to those relays after the release upload; a refusal is only a warning. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qq6RetJnzXvEeXAvSsgvs1
…equests too A broken message fails the check without holding back the other languages' publish. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qq6RetJnzXvEeXAvSsgvs1
…ownload Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qq6RetJnzXvEeXAvSsgvs1
vector_core::search folds every message into one buffer and scans it with memchr's memmem: case and accent folded, CJK without word breaks, quoted phrases, and from:, mentions:, has:, in:, before:, after:, during: filters. GPUI opens it with Cmd/Ctrl+K (every chat) or Cmd/Ctrl+F, the header's magnifier and the chat menu (the open chat), suggests the filter being typed, and opens a result at the message. Slim takes the whole window. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qq6ReurguGC2qWNpRCjenb
Errors, network status, moderation policy wording and the like come from vector-core in English. coretext matches each line back to the format string that wrote it and says it through a core.ftl message, with the values it carried (counts as numbers, so translations can pluralise). Composite lines (policy rule details, clock skew, nested errors) are taken apart first. Shown at toasts, popups, dialog errors, network status, presets, raid and policy reasons, failed sends, embeds and Mini App permissions. Two tests keep it honest: a table entry core no longer writes fails, and new prose in vector-core counts against a per-file allowance until it gets an entry or is judged developer-only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qq6RetJnzXvEeXAvSsgvs1
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qq6RetJnzXvEeXAvSsgvs1
…ts edge The system's first search for fonts that draw the kaomoji (the picker's tab label among them) ran inside the picker's first frame; a background pass shapes their glyphs once after launch. The grid's overdraw drops from 400 px to two rows. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qq6RetJnzXvEeXAvSsgvs1
…s in its own Their entrances and hovers asked the root for frames, so each one redrew the whole window; now only the pane that moves is drawn again. The attach menu asks its own view for frames instead of notifying the root. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qq6RetJnzXvEeXAvSsgvs1
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qq6RetJnzXvEeXAvSsgvs1
Follow the tail only when the timeline is pinned to it, as Tauri latches its pin once the user scrolls up. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qq6RetJnzXvEeXAvSsgvs1
…ice sign-in A touch catches a fling only while it visibly moves what it scrolls; a fling stopped by a list's end is over, and Android flings with its own OverScroller physics. Held picks are read through their own descriptor, which Android lets an app do, unlike reopening the memfd by path. Long file names wrap inside the preview card. A phone being signed in opens on Scan QR Code. Pin to Main Menu shows only in widescreen. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qq6RetJnzXvEeXAvSsgvs1
…button Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qq6RetJnzXvEeXAvSsgvs1
… none A muted subtree keeps drawing but its hitboxes contain no point and its mouse listeners never run, so a tap during a popup, menu or drawer's fade-out reaches the app beneath instead of an inert shield. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qq6RetJnzXvEeXAvSsgvs1
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qq6RetJnzXvEeXAvSsgvs1
…bar in its tab, media at its width on a chat's first frame - A message moves only its own chat in the list: 1000 arrivals over 200 chats of 300 messages went from 446 ms to 19 ms of main-thread work. - The UI drains backend events in 4 ms slices, and the Android main queue yields to the looper after 4 ms, so touches and vsync are served during a sync. - The slim tab underline rests inside its tab and only slides from measured bounds. - The timeline keeps its last width per layout for a new chat's first frame. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qq6RetJnzXvEeXAvSsgvs1
LineLayoutCache kept only last frame's layouts, so a chat, Community, tab or drawer drawn again reshaped all its text in its first frame. Lines a frame stops drawing are now retained (bounded at 3072 lines and 1536 wrapped lines, oldest trimmed). Revisiting a Community: worst frame 9.5 → 4.4 ms, 67 → 0 shape misses; a chat with videos 8.4-11.5 → 4.6-4.9 ms. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qq6RetJnzXvEeXAvSsgvs1
The root render ticked chat models, so a spinning model's frame requests and engine wakes redrew the whole window at 30 fps for as long as it played. The timeline pane now asks for its models' frames; the root only asks while the full-screen viewer is open. Two seconds after opening a chat with a spinning model: whole-window redraws 98 → 3 cold, 59 → 0 warm. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qq6RetJnzXvEeXAvSsgvs1
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qq6RetJnzXvEeXAvSsgvs1
…at list is its own pane - An inline clip ticks in the timeline pane, so its frames redraw that pane, not the window (whole-window redraws over 2.5 s of playback: 301 → 0). - A playing clip asks for its next redraw when its next decoded frame falls due, not every vsync: a 30 fps clip draws 30 times a second (123 → 30/s), drawing time per second of playback down 58%, every frame still shown. - At phone width the chat list draws as a cached pane, so scrolling it leaves the rest of the window alone (whole-window redraws during a scroll: 324 → 0). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qq6RetJnzXvEeXAvSsgvs1
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qq6RetJnzXvEeXAvSsgvs1
A new `keyed` element in vendored GPUI draws its subtree once and, while nothing but its position changes, replays last frame's primitives and hit areas moved to where it now sits. It records with its own clips only and takes the clips around it afresh, so edge fades and partial rows stay right. Views now hear two kinds of notify: data (rebuild) and motion (a scroll or hover moved things). List and overflow scrolls and hover flips are motion. A subtree rebuilds when its view's data changes, the window redraws everything, the pointer is over it, it asked for a frame, or it holds tooltips, deferred draws or text input. List rows sit on whole device pixels so a scroll moves them by whole pixels. GPUI_NO_REPLAY=1 turns it off. Both chat lists use it. Scroll frame on the cloud box (200 chats): wide 2.10 -> 1.29 ms mean, phone width 2.23 -> 1.83 ms. Screenshots after a scroll match the no-replay build pixel for pixel; taps right after a scroll open the same chat in both (8/8). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qq6RetJnzXvEeXAvSsgvs1
draw_stats splits each draw into the root's request layout (renders), layout, prepaint and paint; dev:state reports them as request_layout_prepaint_paint_ms. dev:pan:x,y,dy,n sends n pixel scrolls, one a frame, as a finger pan does. Finger-like pans (12 px a frame) over 200 chats, keyed replay on vs off: wide 2.17 -> 1.20 ms a frame, phone width 2.27 -> 1.67 ms. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qq6RetJnzXvEeXAvSsgvs1
…e again As a layout root of its own, a slim row (height only) shrank to its content: previews stopped truncating and the time ran off the edge. The build is now laid out inside a box of the slot's size. Chat list rows key on the minutes since their last message, so a replayed row never shows a stale "2m", and the list redraws every 30 s as Tauri's list clock does. Stock emoji picker rows are keyed too. devctl `views:1` times each view's prepaint and paint (panes by name) into dev:state. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qq6RetJnzXvEeXAvSsgvs1
…caches A cached view that misses used to redraw every cached view inside it. When it misses only because a view inside it was notified, its render is unchanged, so the views inside may reuse their drawing, as panes under the root already do. Scrolling the emoji picker no longer redraws the timeline beside it. refresh_windows now counts as a hard refresh, so keyed rows redraw on a language switch. GPUI_NO_REPLAY=1 also turns this off, for A/B. Emoji picker finger pan, chat open: 5.0 -> 3.0 ms a frame, prepaint 2.0 -> 0.78 ms, timeline 1.26 -> 0.03 ms. Typing in the composer: 2.8 -> 2.2 ms. Screenshots identical on vs off (picker, typing, wide and slim lists). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qq6RetJnzXvEeXAvSsgvs1
The code block's 10 px scrollbar strip blocked the mouse, wheel included, and did so even with nothing to scroll sideways, so the timeline stalled whenever the pointer rested there. The bar now lets a wheel through, as a page's does, and without overflow the strip is no bar at all. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qq6RetJnzXvEeXAvSsgvs1
…s; editor × over the edge Timeline rows replay their last drawing when scrolled (keyed_measured: any height, measured on build and kept while replaying). Rows that are loading, animating or show a relative time mark themselves volatile and redraw. Selection geometry is re-placed on replay (Window::place). Plain rows keep the same element id so hover state survives the plain/keyed switch on the first frame. 3000-message chat pan, 1280x800: 5.1 -> 3.2 ms a frame, 73% of rows replayed. Screenshots and drag selection after panning match GPUI_NO_REPLAY=1 exactly. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qq6RetJnzXvEeXAvSsgvs1
… overlays [package] `.backdrop_blur_once(r)` blurs what lies behind an element on the first frame it shows (quarter size, two 13-tap passes) and reuses that texture while it stays put, so held frames draw one extra quad and keep the main pass whole. Metal and wgpu read the frame back; a GL surface without COPY_SRC draws that one frame offscreen and copies it over. DirectX leaves the backdrop sharp for now. GPUI_NO_BACKDROP=1 turns it off. Mac GPU: +0.15 ms on the opening frame (1.10 vs 0.94 ms), held frames within noise. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qq6RetJnzXvEeXAvSsgvs1
…-pointer hovers The scrollbar's settle redraw of the chat pane is a motion notify, so it no longer rebuilds every visible row. Content scrolling under a still pointer flips hover without a fade, so rows carried past it don't animate (and rebuild) for 150 ms. A keyed record's hover check covers its hit areas, not only its bounds: a hover toolbar hanging above its row kept a stale highlight on replay. 3000-message chat pan, 1280x800: 3.3-3.4 -> 2.5-3.1 ms a frame, rows replayed 70% -> 85%. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qq6RetJnzXvEeXAvSsgvs1
… around them GPUI marks every view holding a notified one dirty, so a timeline scroll redrew the whole chat pane (header, composer) around it. A cached view now records the cached views drawn inside it (slots: ranges, dispatch parent, draw stacks). When it is dirty but not notified and every dirty view inside it lies in one of its slots, it reuses its last prepaint and paint in pieces around those slots and draws only them afresh (OpenReuse keeps the dispatch nodes still open between pieces). Anything it cannot see into (deferred draws in a reused piece, an uncached dirty view, a11y, zoom, inspector) falls back to a full redraw. Cached view ranges are only reused from the last draw. GPUI_NO_PUNCH=1 turns it off. The scrollbar, the way back, the unread pill and the typing line move into their own pane, redrawn in the same frame as the timeline (Window::redraw_now). 3000-message chat pan, 1280x800: 2.34-2.76 -> 2.22-2.32 ms a frame, prepaint 1.02-1.27 -> 0.80-0.90 ms. Screenshots, drag selection and typing match GPUI_NO_PUNCH=1. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qq6RetJnzXvEeXAvSsgvs1
…on screen first A fresh join showed General's messages only after a multi-page catch-up (35 s on a real join), raced by a sweep of every channel; profiles loaded one REQ pair at a time in join order, and an empty channel's older-page fetch spun on a refused claim. - The opened channel fetches its newest page alone first and paints it; sweeps, resyncs, the volley and core's channel rereads wait on a session foreground gate, and take the channel on screen first. - Visible profiles go to the front of their lane in draw order; the watcher keeps draw order and holds back anything over a batch rather than dropping it; unknown Community members and join rows queue behind. - The profile processor loads a batch with one REQ for every author's metadata and status. - An empty channel does not fetch older pages; a refused claim backs off. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qq6RetJnzXvEeXAvSsgvs1
The root view is now cached and punches through like the panes: a frame dirty only for panes renders those alone. Its per-frame upkeep moves to Window::on_each_draw, eases built at layout ask for frames through after_each_prepaint, and the chrome pane (or upkeep that changes what the root draws) makes it render again via Window::rerender. Deferred draws in reused pieces are carried with their dispatch parents remapped. Timeline pan (3000 messages, 1280x800, cloud): 2.22-2.32 -> 2.03-2.10 ms a frame. Screens, selection, popups, menus and tooltips match GPUI_NO_PUNCH=1. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qq6RetJnzXvEeXAvSsgvs1
sync_channel_events pages on for its continuations after painting the first window, holding the foreground gate (and the background walks behind it) for seconds more. sync_community_channel_head fetches and ingests one window, then the catch-up runs as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qq6RetJnzXvEeXAvSsgvs1
Each address of a page was read after the one before it, and a channel's first paint paid every one of those rounds in series. They are separate reads whose results fold in the same order, so they now run together. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qq6RetJnzXvEeXAvSsgvs1
…tes [package] A neighbour update carries a count and no names; it no longer empties the card's player list. The pill counts named players, else the mesh's count, and each avatar names its player on hover. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qq6RetJnzXvEeXAvSsgvs1
Requested by JSKitty · project thread
A long-lived experiment branch: Vector drawn natively with GPUI instead of a webview, aiming for exact parity in layout, palette, fonts and features with the Tauri client. It isn't meant to merge any time soon; the PR is here so the diff and discussion stay in one place.
What's in this first cut
crates/vector-gpui: its own workspace and lockfile, so it never touches the Tauri client's dependency graph. The only shared-file change is excluding it fromcrates/Cargo.toml. GPUI is pinned to Zedf8cfc7e.uniform_list) and the open chat (virtualisedlistwith date and NEW dividers). The NEW divider stays put while the chat is open.SerializableChat,SlimProfile,Message).data.rsmirrors the JS derivations (getName,chatPreviewText,timeAgo, unread counts), and each helper names the function it copies.src/icons, so an icon changed in the Tauri client arrives here on the next build. Rubik is cut from the shipped variable font into static weights; Inter is bundled too.Parity harness (
reference/)capture.mjsboots the real frontend in Chromium through its debug hot-reload path, usingmock-tauri.jsand the samefixtures.json. It needs no Rust, account or network. It saves a screenshot plus every element's box, font, colour and border.shot.shrenders vector-gpui under Xvfb, andcompare.pyputs the two side by side with a diff.On the 1200×760 chat screen, 1.8% of pixels differ by more than 24/255. Most of that is text anti-aliasing; the remaining offsets are about 1px.
Numbers (release build, Linux, software Vulkan)
libLLVM, lavapipe), which a real GPU driver doesn't load.Known gaps
letter-spacing, so the NEW label spaces its letters by hand.….Generated by Claude Code